SCC-0898 - Search Results View All Link #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
requested changes
Dec 11, 2023
| {bib.numPhysicalItems > ITEMS_PER_SEARCH_RESULT && ( | ||
| <CardActions> | ||
| <RCLink href={`${bib.url}#items-table`}> | ||
| <Text |
There was a problem hiding this comment.
Similar to the other PR, don't render p elements inside a elements. This Link can also be of type "standalone" which you may need to propagate down from the RCLink.
There was a problem hiding this comment.
Good catch, just made both links of the "standalone" type.
charmingduchess
approved these changes
Dec 11, 2023
EdwinGuzman
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://jira.nypl.org/browse/SCC-3898
This PR renders a View All x Items link that leads to the Bib page when the number of physical items exceeds 3.
Notes: