Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCC-3904: Advanced Search page A11y and VQA fixes #59

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

EdwinGuzman
Copy link
Member

Resolves JIRA ticket SCC-3904.

This fixes six main issues found on the Advanced Search page:

  • Removes the DatePicker component for text input components. Accessibility issues were flagged in the DatePicker and the DS team wants to take a step back to fix them. So it's not a blocker, the TextInput component should be used for now.
  • Adds focus to the error message when it is rendered.
  • Updates the error messages to include the work "Error: ..."
  • Adds a basic validation so that the "From" date cannot be bigger than the "To" date.
  • Updates the button group layout for the Clear and Submit button.
  • Moves the date fields to the first column for better visual layout.

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
research-catalog ✅ Ready (Inspect) Visit Preview Dec 13, 2023 4:21pm

@EdwinGuzman
Copy link
Member Author

Passed accessibility and VQA reviews.

Copy link
Contributor

@dgcohen dgcohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It would be good to eventually abstract some of this error handling, but we can address that as a follow up.

@EdwinGuzman EdwinGuzman merged commit 4614937 into main Dec 21, 2023
3 checks passed
@dgcohen dgcohen deleted the SCC-3904/advanced-search-qa branch February 1, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants