Upgrade has_scope #253
Open
Upgrade has_scope #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bagedevimo and the rest of your teammates on |
bagedevimo
force-pushed
the
01-06-Upgrade_has_scope
branch
from
a6e8039
to
fa38013
Compare
Devise 4.0.0 introduced support for Rails 5 Follow up commits will fix deprecations
Devise updated this in version 4.0.0rc1, so this is just bringing us up to the new system: https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#400rc1---2016-02-01
Devise 4.1.0 fixed a race condition with email sending, where an email could try to be sent before the record that email is referring too is not yet persisted [1]. They unfortunately fixed this using an after_commit, which under Rails 4.2 doesn't work with transactional fixtures [2]. This is fixed under Rails 5 [3], so we can just comment these out to get this merged, and get the rails upgrade out, then re-enable these tests. [1] https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#410 [2] config/spec_helper.rb:34 [3] rails/rails@eb72e34
Devise 4.6.0 deprecated the `devise_error_messages!` helper method in favour if just rendering a partial including the library. [1] We can (optionally) copy that partial into our codebase, where we can edit it, and it will be preferentially used over the one in the gem code. However, the existing helper had no customisations so I didn't go down that route yet. [1] https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#460---2019-02-07
Devise 4.2.0 deprecated the Devise::TestHelpers module in favour of the Devise::Test::ControllerHelpers module, which is because they wanted to split the different test helpers into different modules. https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#420---2016-07-01
The previous version of has_scope doesn't support Rails 5. Support for Rails 5 was introduced in version 7.0, but we may as well as go all the way to 0.7.2 which is the last version that supports Rails < 5.2. https://github.com/heartcombo/has_scope/blob/main/CHANGELOG.md#072
bagedevimo
force-pushed
the
01-06-Upgrade_has_scope
branch
from
fa38013
to
7b670e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of has_scope doesn't support Rails 5. Support for
Rails 5 was introduced in version 7.0, but we may as well as go all the
way to 0.7.2 which is the last version that supports Rails < 5.2.
https://github.com/heartcombo/has_scope/blob/main/CHANGELOG.md#072