Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system/mailer settings to db/seeds.rb #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Holmes98
Copy link
Member

@Holmes98 Holmes98 commented Jan 6, 2024

These are currently created during migrations, but we plan to remove this behaviour in #243. The values are left blank, as they need to be set manually anyway.

@tom93 suggested using an environment variable for the password; I didn't bother, but feel free to add that if you prefer.

Commit message can be changed if we decide not to go with #243.

These are currently created during migrations, but we plan to
remove this behaviour in #243. The values are left blank, as
they need to be set manually anyway.
@coveralls
Copy link

Coverage Status

coverage: 37.131%. remained the same
when pulling 6d2bd1b on seed-mailer-settings
into 57b299d on master.

@bagedevimo
Copy link
Contributor

IMO this is worth doing even regardless of migration changes, as it makes the whole thing more complete with just a db:seed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants