Corrected Slider Behavior #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug with not being able to obtain edge values of slider (0.0, 1.0) on mobile. Corrected slider thumb touch position to center itself to the touch rather than to the right of the touch. This should fix the bugs mentioned in most cases, but if the view is nested in more containers we may need to obtain the padding/margin offsets for the container view. I'll address that if there's enough demand.
Fixed bug with not being able to obtain edge values of slider (0.0, 1.0) on mobile. Corrected slider thumb touch position to center itself to the touch rather than to the right of the touch. This should fix the bugs mentioned in most cases, but if the view is nested in more containers we may need to obtain the padding/margin offsets for the container view. I'll address that if there's enough demand.
Made slider more user-friendly on mobile by continuing to read the touch events even when the touch is moved slightly (sliderHitSlop points) out of the bounds of the slider's box once started. outOfSlider is now unnecessary due to slider bounds being handled in sliderThumbAdjuster. There is a bug in the implementation of locationX on Android so using pageX (with appropriate padding/margin offset calculations) is more reliable. Still may need more padding/margin calculations for specific use-cases, but very usable currently.
Corrected default value for sliderHitSlop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile there was a bug where I couldn't select the edge values of the slider (0.0, 1.0). It would allow me to get very close, but I could never slide to #000000 or #ffffff.
The slider's thumb also would position itself to the right of the touch rather than centering on it.
I corrected both of those issues.