Fix: Unreachable status should be notifiable #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was revisiting #873 and realized it was probably a mistake to stop notifications if only one of the parents are down (flukes are a thing, hence check_attempts). Making a host no longer notify if all it's parents are down would make sense, except that's what unreachable is, and you can configure whether or not you get unreachable notifications so I'm removing that check for hosts.
The thing I'm a little hung up on is what the expected behavior is for services. There isn't a host_unreachable equivalent (maybe state_unknown but I think that's a little different) so I feel a little bit better about disabling checks if it's host parents are all down, which is what I'm doing here.
Regardless, I'm looking for some feedback from the community as to what they expect from service notifications in instances described in #873