Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precompile cache action in backend #16

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JBlocks
Copy link
Contributor

@JBlocks JBlocks commented Aug 14, 2019

The precompile backend action (system toolbar) is now compatible with the request and response interface

@NamelessCoder
Copy link
Owner

This changes the TYPO3 compatibility of the extension and shouldn't enable strict types or declare strict returns. AFAIK it is possible to have compatible signatures for both v9 and v8 LTS versions.

@JBlocks
Copy link
Contributor Author

JBlocks commented Aug 14, 2019

This changes the TYPO3 compatibility of the extension and shouldn't enable strict types or declare strict returns. AFAIK it is possible to have compatible signatures for both v9 and v8 LTS versions.

Okay. Removed the declare(strict_types=1);, strict return type and added parameter signature null to get compatible with version 8. Version 8 has no middleware and no request and response interface as method signature. So we have $request = null and $response = null in version 8. I'm totally fine with this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants