Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note regarding use of LDOS feature in lossy media #2894

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Aug 27, 2024

Adds a note to Tutorial/Local Density of States describing the limitations of using the LDOS feature for lossy media.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.71%. Comparing base (f29a8c7) to head (b9c00e3).
Report is 32 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2894      +/-   ##
==========================================
- Coverage   73.81%   73.71%   -0.11%     
==========================================
  Files          18       18              
  Lines        5423     5444      +21     
==========================================
+ Hits         4003     4013      +10     
- Misses       1420     1431      +11     

@stevengj stevengj merged commit 3dde1f4 into NanoComp:master Aug 29, 2024
5 checks passed
@oskooi oskooi deleted the ldos_lossy_media branch August 29, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants