Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the radiation pattern of a nonaxisymmetric dipole integrated in the azimuthal direction is rotationally invariant #2951

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Dec 30, 2024

Adds a note to Tutorial/Cylindrical Coordinates/Nonaxisymmetric Dipole Sources to menion that integrating $\phi$ over the range [0, 2π] for a nonaxisymmetric dipole is essentially equivalent to placing a series of linearly polarized dipoles along the circumference of a circle with fixed radius.

…ated in the azimuthal direction is rotationally invariant
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.71%. Comparing base (f29a8c7) to head (0be9534).
Report is 40 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2951      +/-   ##
==========================================
- Coverage   73.81%   73.71%   -0.10%     
==========================================
  Files          18       18              
  Lines        5423     5449      +26     
==========================================
+ Hits         4003     4017      +14     
- Misses       1420     1432      +12     

@stevengj stevengj merged commit 1ee8c60 into NanoComp:master Jan 3, 2025
2 checks passed
@oskooi oskooi deleted the nonaxisymmetric_dipole_clarify branch January 4, 2025 01:54
@villadsegede
Copy link

Just out of curiosity: What is your experience with solver efficiency when you introduce complex light sources? In the use cases I've tested, the advantage of rotational design symmetry was lost in practice, and I could imagine it is the same here? (i.e. one might as well have run embarassingly parallel 3D simulations using ODA, for example)

... And then there can still be other reasons for or against (i.e. once you have the radial basis solutions, you might as well recombine them to represent several sources if so desired)

@stevengj
Copy link
Collaborator

stevengj commented Jan 6, 2025

I'm not sure what you mean by "complex light sources". Certainly for off-axis planewaves we find it's still more efficient to use cylindrical coordinates, unless the angle is close to 90°. 3d simulations are expensive, and the cylindrical simulations at different m's are embarassingly parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants