Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waveguide mode converter readme, schematic diagram, design patterns, and script #11

Merged
merged 10 commits into from
Jun 14, 2022

Conversation

ianwilliamson
Copy link
Collaborator

First step in tackling #6. Specifically, this PR adds a readme to document the parameters and add a schematic for the waveguide mode converter. This is based on the results from our paper.

@stevengj
Copy link
Contributor

Great, thanks! Can you also add a CSV file for data of the the optimized structure, or will that be a separate PR?

@ianwilliamson
Copy link
Collaborator Author

Great, thanks! Can you also add a CSV file for data of the the optimized structure, or will that be a separate PR?

Yes, will follow up with additional PRs for (1) code to run the simulations and (2) the design patterns.

@stevengj
Copy link
Contributor

Thanks for adding the CSV files; are these documented in the README?

@ianwilliamson
Copy link
Collaborator Author

Thanks for adding the CSV files; are these documented in the README?

Not yet. Will take a stab at documenting them and adding a script for running the simulations.

For FOM / optimization objective, I am thinking that we can report worst case transmission over the bandwidth of interest. I will have the script print this out.

@ianwilliamson
Copy link
Collaborator Author

Will take a stab at documenting them and adding a script for running the simulations.

For FOM / optimization objective, I am thinking that we can report worst case transmission over the bandwidth of interest. I will have the script print this out.

Documentation has been added. I also add the script for reporting the performance metrics.

A follow up step will be to have the script run the ruler on the designs, but currently this is not possible as the ruler.py script is not setup to be imported as a Python module. It also seems like there is a copy of ruler.py under the meta lens module.

@ianwilliamson ianwilliamson changed the title Add waveguide mode converter readme and schematic diagram Add waveguide mode converter readme, schematic diagram, design patterns, and script Jun 14, 2022
@stevengj stevengj merged commit 2494cd6 into NanoComp:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants