Ekirjasto 92 fix UI tab bar text size #71
+15
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natlibfi-kaisa
requested review from
natlibfi-ptalosel and
NatLibFi-JoonaKupe
NatLibFi-JoonaKupe
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this do?
The UI tab bar font size is fixed to a certain size depending on the device. Font size does not adapt to the user's font size preferences.
Why are we doing this?
Large Content Viewer displays the titles and icons as large text and image as long as dynamic fonts are applied in the font.
The problem we had before of the UITabBar titles being enlarged when the font size was changed in Preferences, was due to setting the font size twice in TPPAppDelegate.swift.
How should this be tested?
Tested in iPhone 15, iPad 10th generation and iPhone SE simulators. Note that I wasn't able to confirm that Large Content Viewer works on iPhone SE.