Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more metadata in the anglerfish report #88

Open
FranBonath opened this issue Aug 19, 2024 · 3 comments
Open

add more metadata in the anglerfish report #88

FranBonath opened this issue Aug 19, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@FranBonath
Copy link
Contributor

Currently it is somewhat difficult to connect the Anglerfish report to a flowcell, if all you have is the report itself. It would be nice to include at least the flowcell / run folder name, so we know from which run the data originated.
Further, adding the pool name can help greatly in cases where we have different pools for the same project.

Finally, I would include the amount of "reads mapped to samples" in addition to reads mapping to adapters to the base statistic on top of the report.

Thank you for your consideration :)

@remiolsen
Copy link
Member

Currently it is somewhat difficult to connect the Anglerfish report to a flowcell, if all you have is the report itself. It would be nice to include at least the flowcell / run folder name, so we know from which run the data originated.
Further, adding the pool name can help greatly in cases where we have different pools for the same project.

I don't see any problem adding these these as optional metadata to anglerfish run, e.g. --flowcell and --pool and storing them in the report(s). I want anglerfish to be as portable as possible and not rely on any folder-structure to determine these things and envision it would be some upstream processes that have the task of filling these values, e.g. TACA at NGI.

Finally, I would include the amount of "reads mapped to samples" in addition to reads mapping to adapters to the base statistic on top of the report.

I think what you ask for is partly related to #64. If so, I think both number of reads matching to barcodes and number of reads not matching to barcodes should be reported.

@remiolsen remiolsen added the enhancement New feature or request label Aug 19, 2024
@remiolsen remiolsen added this to the 1.0.0 milestone Aug 19, 2024
@kedhammar
Copy link
Collaborator

@remiolsen Do we want to create new args for each metadata key or can we simply have an arg accepting any custom metadata key-value pairs? E.g. --metadata { 'flowcell': 'asdf', 'run_dir': '/asdf/asdf' }?

@remiolsen
Copy link
Member

@kedhammar Yes, that would be a tidier solution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants