errorprone :: ConstantField for PickUpPlace (#985)

NationalSecurityAgency · Oct 21, 2024 · 5d4e987 · 5d4e987
1 parent 6c3ebe2
commit 5d4e987
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/emissary/pickup/PickUpPlace.java b/src/main/java/emissary/pickup/PickUpPlace.java
@@ -77,7 +77,7 @@ public abstract class PickUpPlace extends ServiceProviderPlace implements IPickU
     protected List<String> initialFormValues = Collections.emptyList();
 
     // Metadata items that should always be copied to children
-    protected Set<String> ALWAYS_COPY_METADATA_VALS = new HashSet<>();
+    protected Set<String> alwaysCopyMetadataVals = new HashSet<>();
 
     protected boolean useObjectTraceLogger = false;
 
@@ -183,7 +183,7 @@ protected void configurePickUpPlace() {
             logger.warn("Cannot find agent pool!");
         }
 
-        ALWAYS_COPY_METADATA_VALS = configG.findEntriesAsSet("ALWAYS_COPY_METADATA");
+        alwaysCopyMetadataVals = configG.findEntriesAsSet("ALWAYS_COPY_METADATA");
 
         // Whether or not to use the objectTrace logger
         useObjectTraceLogger = configG.findBooleanEntry("USE_OBJECT_TRACE_LOGGER", useObjectTraceLogger);

diff --git a/src/main/java/emissary/place/MultiFileServerPlace.java b/src/main/java/emissary/place/MultiFileServerPlace.java
@@ -88,7 +88,7 @@ public boolean shouldProcess(IBaseDataObject d) {
      * @param children the destination for parameters to be copied
      */
     protected void addParentInformation(IBaseDataObject parent, List<IBaseDataObject> children) {
-        IBaseDataObjectHelper.addParentInformationToChildren(parent, children, false, ALWAYS_COPY_METADATA_VALS, myKey, kff);
+        IBaseDataObjectHelper.addParentInformationToChildren(parent, children, false, alwaysCopyMetadataVals, myKey, kff);
     }
 
     /**
@@ -99,7 +99,7 @@ protected void addParentInformation(IBaseDataObject parent, List<IBaseDataObject
      * @param nullifyFileType if true the child fileType is nullified after the copy
      */
     protected void addParentInformation(IBaseDataObject parent, @Nullable List<IBaseDataObject> children, boolean nullifyFileType) {
-        IBaseDataObjectHelper.addParentInformationToChildren(parent, children, nullifyFileType, ALWAYS_COPY_METADATA_VALS, myKey, kff);
+        IBaseDataObjectHelper.addParentInformationToChildren(parent, children, nullifyFileType, alwaysCopyMetadataVals, myKey, kff);
     }
 
     /**
@@ -109,7 +109,7 @@ protected void addParentInformation(IBaseDataObject parent, @Nullable List<IBase
      * @param child the destination for parameters to be copied
      */
     protected void addParentInformation(IBaseDataObject parent, IBaseDataObject child) {
-        IBaseDataObjectHelper.addParentInformationToChild(parent, child, false, ALWAYS_COPY_METADATA_VALS, myKey, kff);
+        IBaseDataObjectHelper.addParentInformationToChild(parent, child, false, alwaysCopyMetadataVals, myKey, kff);
     }
 
     /**
@@ -120,6 +120,6 @@ protected void addParentInformation(IBaseDataObject parent, IBaseDataObject chil
      * @param nullifyFileType if true the child fileType is nullified after the copy
      */
     protected void addParentInformation(@Nullable IBaseDataObject parent, @Nullable IBaseDataObject child, boolean nullifyFileType) {
-        IBaseDataObjectHelper.addParentInformationToChild(parent, child, nullifyFileType, ALWAYS_COPY_METADATA_VALS, myKey, kff);
+        IBaseDataObjectHelper.addParentInformationToChild(parent, child, nullifyFileType, alwaysCopyMetadataVals, myKey, kff);
     }
 }