Apply suggestions from code review

Co-authored-by: drivenflywheel <[email protected]>
NationalSecurityAgency · Jan 7, 2025 · cd8191c · cd8191c
1 parent 11018ad
commit cd8191c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/main/java/emissary/core/BaseDataObject.java b/src/main/java/emissary/core/BaseDataObject.java
@@ -291,15 +291,10 @@ public BaseDataObject(final byte[] newData, final String name, @Nullable final S
 
     public BaseDataObject(final byte[] newData, final String name, @Nullable final String form, @Nullable final String fileType,
             IBaseDataObject tld) {
-        setData(newData);
-        setFilename(name);
-        if (form != null) {
-            pushCurrentForm(form);
-        }
+        this(newData, name, form, tld);
         if (fileType != null) {
             this.setFileType(fileType);
         }
-        this.tld = tld;
     }
 
     /**

diff --git a/src/main/java/emissary/core/IBaseDataObject.java b/src/main/java/emissary/core/IBaseDataObject.java
@@ -1013,7 +1013,7 @@ default String getParameterAsConcatString(final String key, final String sep) {
     void setTransactionId(String transactionId);
 
     /**
-     * Return the Top level document or null if there is none for this IBaseDataObject
+     * Return the top level document or null if there is none for this IBaseDataObject
      *
      * @return The TLD IBaseDataObject
      */