address KffFile logging (#593)

NationalSecurityAgency · Sep 21, 2023 · ef13f6a · ef13f6a
1 parent ee58307
commit ef13f6a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/main/java/emissary/kff/KffFile.java b/src/main/java/emissary/kff/KffFile.java
@@ -178,8 +178,7 @@ private boolean binaryFileSearch(@Nonnull byte[] hash, long crc) {
                 }
             }
         } catch (IOException e) {
-            logger.warn("Exception reading KffFile: {}", e.getMessage());
-            return false;
+            logger.warn("Exception reading KffFile", e);
         }
 
         // not found

diff --git a/src/test/java/emissary/kff/KffFileTest.java b/src/test/java/emissary/kff/KffFileTest.java
@@ -114,7 +114,7 @@ void testConcurrentKffFileCheckCalls() throws Exception {
 
         List<KffFileCheckTask> callables = createCallableTasksForParallelExecution(testInputs);
 
-        logger.info("testing {} invocations, with {} that should return true", callables.size(), numberOfKffEntriesInTestFile);
+        logger.debug("testing {} invocations, with {} that should return true", callables.size(), numberOfKffEntriesInTestFile);
 
         ExecutorService executorService = null;
         try {
@@ -272,7 +272,7 @@ static class KffFileCheckTask implements Callable<Boolean> {
         public Boolean call() throws Exception {
             boolean actual = kffFile.check("ignored param", csr);
             // increase this log level to view stream of executions and results
-            LOGGER.info("expected {}, got {}", expectedResult, actual);
+            LOGGER.debug("expected {}, got {}", expectedResult, actual);
             return expectedResult.equals(actual);
         }
     }