Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VersionPlace: if version is release, do not add date #1004

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

sambish5
Copy link
Collaborator

makes it so if version is release (i.e. 8.15.0, and not 8.15.0-SNAPSHOT), make it so even if includeDate is true, the version added to the payload is just the version numbering.

@sambish5 sambish5 requested a review from jpdahlke October 30, 2024 18:41
@sambish5 sambish5 marked this pull request as draft October 30, 2024 19:26
@sambish5 sambish5 marked this pull request as ready for review October 31, 2024 20:05
@cfkoehler cfkoehler self-requested a review November 1, 2024 09:13
Copy link
Collaborator

@cfkoehler cfkoehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and makes sense to me. Nice work

@jpdahlke jpdahlke added this to the v8.17.0 milestone Nov 1, 2024
@DonResnik DonResnik self-requested a review November 1, 2024 13:44
@jpdahlke jpdahlke added the enhancement An enhancement or update to an existing feature label Nov 1, 2024
@jpdahlke jpdahlke merged commit c657040 into NationalSecurityAgency:main Nov 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or update to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants