Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize static instance of EmissaryServer #1024

Merged
merged 2 commits into from
Jan 7, 2025
Merged

initialize static instance of EmissaryServer #1024

merged 2 commits into from
Jan 7, 2025

Conversation

jpdahlke
Copy link
Collaborator

  • removes the need for node.mode system property (get from command or default value)
  • no longer need to check namespace binding to determine state
  • deprecate stop/status methods for future cleanup

Pulled out of #900 but stops short of changing mode to enum and changing command validator.

@jpdahlke jpdahlke added framework This change will impact the core framework improvement A change that makes something easier to use labels Dec 16, 2024
@jpdahlke jpdahlke requested a review from dev-mlb December 16, 2024 22:27
dev-mlb
dev-mlb requested changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dev-mlb dev-mlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits, but otherwise looks good

src/main/java/emissary/server/EmissaryServer.java Show resolved Hide resolved
src/main/java/emissary/pickup/WorkSpace.java Show resolved Hide resolved
@fbruton fbruton self-requested a review December 19, 2024 21:58
@jpdahlke jpdahlke added this to the v8.20.0 milestone Dec 23, 2024
fbruton
fbruton requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@fbruton fbruton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend suggesting alternative methods in the Javadoc for deprecated methods where applicable.

@jpdahlke
Copy link
Collaborator Author

jpdahlke commented Jan 7, 2025

Recommend suggesting alternative methods in the Javadoc for deprecated methods where applicable.

Some of these have no other option and will be removed as part of future updates. I marked them as Deprecated vs removing them to reduce the overall scope of changes. I would be happy to address this in the next round of changes.

@fbruton fbruton self-requested a review January 7, 2025 17:36
@jpdahlke jpdahlke merged commit 1e9b231 into NationalSecurityAgency:main Jan 7, 2025
12 checks passed
rpg36 pushed a commit to rpg36/emissary that referenced this pull request Jan 7, 2025
@jpdahlke
initialize static instance of EmissaryServer (NationalSecurityAgency#…
f1e4fb2 
…1024)
ldhardy pushed a commit to ldhardy/emissary that referenced this pull request Jan 9, 2025
@jpdahlke @ldhardy
initialize static instance of EmissaryServer (NationalSecurityAgency#…
a7a1aa4 
…1024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-mlb dev-mlb dev-mlb approved these changes

@fbruton fbruton fbruton approved these changes

Assignees
No one assigned
Labels
framework This change will impact the core framework improvement A change that makes something easier to use
Projects
None yet
Milestone
v8.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jpdahlke @fbruton @dev-mlb