creates an abstract RefreshableServiceProviderPlace for config reloading #1035
+281
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😍 |
| * | ||
| * @throws IOException if there is an issue loading the config | ||
| */ | ||
| protected void refresh() throws IOException { |
There was a problem hiding this comment.
It occurs to me that this might not be safe to call while the place is actively processing an IBDO, or while trying to identify the next place that should process a payload.
dev-mlb
changed the title
drivenflywheel
requested changes
Jan 13, 2025
| return this.invalid.get(); | ||
| } | ||
|
|
||
| public void invalidate() { |
There was a problem hiding this comment.
- Might want to add a Javadoc comment stating that
invalidatemust be called before callingrefresh. - Might want to mark this method as
finaland do the same to therefreshoverloads
| } | ||
|
|
||
| @Test | ||
| void testReconfigure() { |
There was a problem hiding this comment.
Consider adding another test (or block within this test) that calls place.refresh() without first calling invalidate()
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * |
There was a problem hiding this comment.
Suggested change
| * | |
| * ServiceProviderPlace that supports on-demand refresh of its configuration |
drivenflywheel
previously approved these changes
Jan 14, 2025
drivenflywheel
previously approved these changes
Jan 14, 2025
dev-mlb
force-pushed
the
refresh-srv-prvd-place
branch
from
a5e8bc2 to
40e4ccb
Compare
|
Sorry, the directory place change doesn't need to go out with this round of changes. |
drivenflywheel
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first cut into handling place config refreshing -- this does not handle service key changes at this time