Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update methods in OSReleaseUtil #1038

Merged
merged 3 commits into from
Jan 7, 2025
Merged

update methods in OSReleaseUtil #1038

merged 3 commits into from
Jan 7, 2025

Conversation

jpdahlke
Copy link
Collaborator

@jpdahlke jpdahlke commented Jan 6, 2025 •
edited
Loading

  • update isUbuntu method to just check the ID value
  • add centos and rhel checks
  • condense test code
  • update getMajorVersion to getMajorReleaseVersion to deconflict with maven's os.detected.version.major which is the kernel version and os.detected.release.version which matches the ID_VERSION value

@jpdahlke jpdahlke requested a review from fbruton January 6, 2025 23:03
@jpdahlke jpdahlke added the enhancement An enhancement or update to an existing feature label Jan 6, 2025
@jpdahlke jpdahlke added this to the v8.20.0 milestone Jan 6, 2025
@cfkoehler cfkoehler self-requested a review January 7, 2025 15:36
fbruton
fbruton previously approved these changes Jan 7, 2025
View reviewed changes
@fbruton fbruton self-requested a review January 7, 2025 16:24
@jpdahlke jpdahlke requested a review from cfkoehler January 7, 2025 16:31
@jpdahlke jpdahlke merged commit ac9d7f3 into NationalSecurityAgency:main Jan 7, 2025
12 checks passed
rpg36 pushed a commit to rpg36/emissary that referenced this pull request Jan 7, 2025
@jpdahlke
update methods in OSReleaseUtil (NationalSecurityAgency#1038)
ea8df54
ldhardy pushed a commit to ldhardy/emissary that referenced this pull request Jan 9, 2025
@jpdahlke @ldhardy
update methods in OSReleaseUtil (NationalSecurityAgency#1038)
378738b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfkoehler cfkoehler cfkoehler approved these changes

@fbruton fbruton fbruton approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or update to an existing feature
Projects
None yet
Milestone
v8.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jpdahlke @fbruton @cfkoehler