Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple dependency updates, remove rhino #220

Merged
merged 3 commits into from
Apr 11, 2022
Merged

multiple dependency updates, remove rhino #220

merged 3 commits into from
Apr 11, 2022

Conversation

jpdahlke
Copy link
Collaborator

@jpdahlke jpdahlke commented Apr 8, 2022

Update some of the dependencies covered in #201 while avoiding some of the api breaking or gnarly ones.

@jpdahlke jpdahlke requested a review from ukengineer925 April 8, 2022 23:17
@jpdahlke jpdahlke marked this pull request as draft April 8, 2022 23:44
@jpdahlke jpdahlke added the dependencies This updates a dependency version label Apr 9, 2022
ukengineer925
ukengineer925 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@ukengineer925 ukengineer925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpdahlke jpdahlke marked this pull request as ready for review April 11, 2022 18:38
@jpdahlke jpdahlke requested a review from fbruton April 11, 2022 18:38
@cfkoehler cfkoehler self-requested a review April 11, 2022 19:07
@jpdahlke jpdahlke merged commit b2a1460 into NationalSecurityAgency:master Apr 11, 2022
@jpdahlke jpdahlke added this to the v7.5.0 milestone Apr 12, 2022
andrewbp pushed a commit to andrewbp/emissary that referenced this pull request Jul 5, 2022
@jpdahlke @andrewbp
multiple dependency updates, migrate to jdom2, remove rhino (National…
aeb2548 
…SecurityAgency#220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukengineer925 ukengineer925 ukengineer925 approved these changes

@cfkoehler cfkoehler cfkoehler approved these changes

@fbruton fbruton Awaiting requested review from fbruton

Assignees
No one assigned
Labels
dependencies This updates a dependency version
Projects
None yet
Milestone
v7.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jpdahlke @cfkoehler @ukengineer925