Identify invalid IBDO data/array modifications. #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdcove2
force-pushed
the
IbdoArrayModification
branch
3 times, most recently
from
170619a to
27c789f
Compare
drivenflywheel
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Overall approach looks good. Could use a little cleanup to improve readability and maintainability.
See commit 7e901af on the PR_538_extract_SafeUsageChecker branch for a suggested refactor to help isolate the safe usage checks.
jdcove2
force-pushed
the
IbdoArrayModification
branch
from
27c789f to
95fc212
Compare
drivenflywheel
requested changes
Aug 24, 2023
jdcove2
force-pushed
the
IbdoArrayModification
branch
from
95fc212 to
16dab83
Compare
smcgrattan
previously approved these changes
Sep 1, 2023
|
Should this be feature flagged and defaulted to off to begin integration? |
jpdahlke
previously requested changes
Sep 18, 2023
Should be relatively easy to add a SafeUsageChecker.cfg file with an |
jdcove2
dismissed stale reviews from smcgrattan and drivenflywheel
via
0a26a76
jdcove2
force-pushed
the
IbdoArrayModification
branch
from
16dab83 to
0a26a76
Compare
drivenflywheel
previously approved these changes
Sep 18, 2023
drivenflywheel
requested changes
Sep 20, 2023
jdcove2
force-pushed
the
IbdoArrayModification
branch
from
4f7a4c1 to
9c1e6e6
Compare
jdcove2
force-pushed
the
IbdoArrayModification
branch
from
9c1e6e6 to
1ccf908
Compare
drivenflywheel
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR identifies invalid modifications to the IBDO data/array. This pertains only to IBDO data returned as a byte array since data returned as a ChannelFactory is immutable. An invalid modification is when a byte array is returned, the elements are modified and IBDO.setData(...)/IBDO.setChannelFactory(...) is NOT called. The problem occurs when the IBDO data is backed by a channel factory, a byte array is created and returned from the ChannelFactory, the byte array is modified and then the place competes with the byte array being garbage collected without the modifications being given back to the IBDO.