Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated runcommand and main-runner #568

Merged
merged 5 commits into from
Dec 12, 2023
Merged

remove deprecated runcommand and main-runner #568

merged 5 commits into from
Dec 12, 2023

Conversation

dev-mlb
Copy link
Collaborator

@dev-mlb dev-mlb commented Sep 9, 2023 •
edited
Loading

Will have merge conflicts with #561

@dev-mlb dev-mlb added tech-debt Low-impact cleanup and upkeep integration A breaking change where effort will be required downstream to resolve labels Sep 9, 2023
@dev-mlb dev-mlb added this to the v8.0.0-M6 milestone Sep 9, 2023
This was referenced Sep 9, 2023
Merged
Merged
Merged
drivenflywheel
drivenflywheel previously approved these changes Sep 12, 2023
View reviewed changes
@jpdahlke jpdahlke self-requested a review September 12, 2023 20:27
@dev-mlb dev-mlb force-pushed the deprecated-run-main branch from e20ff51 to e554909 Compare September 18, 2023 12:21
@jpdahlke jpdahlke modified the milestones: v8.0.0-M6, v8.0.0-M7 Sep 19, 2023
jpdahlke
jpdahlke requested changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@jpdahlke jpdahlke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commons-cli dependency can get removed with this as well it seems?

@dev-mlb dev-mlb force-pushed the deprecated-run-main branch from e554909 to 5ffe7d4 Compare September 26, 2023 20:00
@jpdahlke jpdahlke modified the milestones: v8.0.0-M7, v8.0.0-M8 Oct 2, 2023
@dev-mlb dev-mlb force-pushed the deprecated-run-main branch from 5ffe7d4 to fa941a2 Compare October 3, 2023 22:40
@jpdahlke jpdahlke modified the milestones: v8.0.0-M8, v8.0.0-M9 Oct 5, 2023
@cfkoehler cfkoehler modified the milestones: v8.0.0-M9, v8.0.0-M10 Nov 7, 2023
@jpdahlke jpdahlke modified the milestones: v8.0.0-M10, v8.0.0-M11 Nov 14, 2023
@jpdahlke jpdahlke self-requested a review December 12, 2023 14:52
@cfkoehler cfkoehler self-requested a review December 12, 2023 15:08
@jpdahlke jpdahlke merged commit 244e740 into NationalSecurityAgency:master Dec 12, 2023
9 checks passed
@dev-mlb dev-mlb deleted the deprecated-run-main branch December 13, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sambish5 sambish5 sambish5 approved these changes

@jpdahlke jpdahlke jpdahlke approved these changes

@drivenflywheel drivenflywheel drivenflywheel approved these changes

@cfkoehler cfkoehler Awaiting requested review from cfkoehler

Assignees
No one assigned
Labels
integration A breaking change where effort will be required downstream to resolve tech-debt Low-impact cleanup and upkeep
Projects
None yet
Milestone
v8.0.0-M11
Development

Successfully merging this pull request may close these issues.
5 participants
@dev-mlb @drivenflywheel @jpdahlke @sambish5 @cfkoehler