Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper to find preferredData by regex and add to Analyzer #594

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Add helper to find preferredData by regex and add to Analyzer #594

merged 2 commits into from
Oct 2, 2023

Conversation

fbruton
Copy link
Collaborator

@fbruton fbruton commented Sep 20, 2023

No description provided.

@fbruton fbruton force-pushed the preferredData-regex branch from 5b9cba8 to 72039de Compare September 20, 2023 12:50
@jpdahlke jpdahlke added this to the v8.0.0-M7 milestone Sep 20, 2023
@fbruton fbruton changed the title Add helper to find preferredData to find by regex and add to Analyzer Add helper to find preferredData by regex and add to Analyzer Sep 20, 2023
drivenflywheel
drivenflywheel reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, only cosmetic.

src/test/java/emissary/core/IBaseDataObjectHelperTest.java Outdated Show resolved Hide resolved
src/main/java/emissary/analyze/Analyzer.java Outdated Show resolved Hide resolved
drivenflywheel
drivenflywheel approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dev-mlb dev-mlb added the integration A breaking change where effort will be required downstream to resolve label Sep 26, 2023
@jpdahlke jpdahlke merged commit f580cd9 into NationalSecurityAgency:master Oct 2, 2023
@jpdahlke jpdahlke added the enhancement An enhancement or update to an existing feature label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-mlb dev-mlb dev-mlb approved these changes

@drivenflywheel drivenflywheel drivenflywheel approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or update to an existing feature integration A breaking change where effort will be required downstream to resolve
Projects
None yet
Milestone
v8.0.0-M7
Development

Successfully merging this pull request may close these issues.
4 participants
@fbruton @drivenflywheel @dev-mlb @jpdahlke