Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addressing unexpected place startups #598

Merged
merged 2 commits into from
Nov 7, 2023
Merged

addressing unexpected place startups #598

merged 2 commits into from
Nov 7, 2023

Conversation

sambish5
Copy link
Collaborator

This logs the invisible places started up during server startup. In the future, we could build out functionality for stopping invisible places that started up unannounced.

@sambish5 sambish5 requested a review from jpdahlke September 27, 2023 19:12
@jpdahlke jpdahlke added this to the v8.0.0-M7 milestone Oct 2, 2023
@jpdahlke jpdahlke added the feature A new feature that does not exist today label Oct 2, 2023
@jpdahlke jpdahlke modified the milestones: v8.0.0-M7, v8.0.0-M8 Oct 3, 2023
@cfkoehler cfkoehler self-requested a review October 10, 2023 17:21
cfkoehler
cfkoehler previously approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@cfkoehler cfkoehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and forced the behavior so looks good to me

jdcove2
jdcove2 requested changes Oct 10, 2023
View reviewed changes
src/main/java/emissary/admin/Startup.java Show resolved Hide resolved
src/main/java/emissary/admin/Startup.java Outdated Show resolved Hide resolved
@jpdahlke jpdahlke modified the milestones: v8.0.0-M8, v8.0.0-M9 Oct 11, 2023
@sambish5 sambish5 force-pushed the invis-place-startup branch from 1183a25 to 09542df Compare October 17, 2023 13:28
@sambish5
Copy link
Collaborator Author

so a couple of updates to this pr:

  • rather than the verify method not returning anything, I've made it return a boolean. Feel this will be useful in the future for wanting Emissary to shutdown IF places are started invisibly, but for now it still at least currently logs invis place startups as well.
  • @jdcove2 mentioned moving activeDirPlaces to the method, I currently left that out, as I think it may be useful to elsewhere for shutdown later on, and if not, then I can move it within the method.
  • wrote out unit test to test the functionality of verifyNoInvisiblePlaceStarted

@cfkoehler cfkoehler merged commit 5794d03 into NationalSecurityAgency:master Nov 7, 2023
9 checks passed
@drivenflywheel drivenflywheel mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfkoehler cfkoehler cfkoehler approved these changes

@jdcove2 jdcove2 jdcove2 approved these changes

@jpdahlke jpdahlke Awaiting requested review from jpdahlke

Assignees
No one assigned
Labels
feature A new feature that does not exist today
Projects
None yet
Milestone
v8.0.0-M9
Development

Successfully merging this pull request may close these issues.
4 participants
@sambish5 @jdcove2 @cfkoehler @jpdahlke