Adding search ability in directory action in API #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambish5
added
feature
cfkoehler
reviewed
Dec 19, 2023
There was a problem hiding this comment.
The variable declarations flagged on this rule: https://rules.sonarsource.com/javascript/RSPEC-3504/?search=Variables%20should%20be%20declared%20with%20%22let%22%20or%20%22const%22
I don't know java script very well so feel free to disregard my suggestions if you do not agree with them.
Otherwise nice work the search is very helpful!
…s based on review
|
Made the changes to the js based on your review @cfkoehler, and changed the files to follow to indent rule you wanted @jpdahlke |
cfkoehler
approved these changes
Dec 30, 2023
jpdahlke
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built out the code to add a table search in DumpDirectory API to be able to better see active places.