Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Initialization Race Condition in DisposeHelperTest #626

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fixed Initialization Race Condition in DisposeHelperTest #626

merged 4 commits into from
Nov 29, 2023

Conversation

nixon124
Copy link
Collaborator

@nixon124 nixon124 commented Nov 20, 2023 •
edited
Loading

Fixed an initialization race condition that occurred in DisposeHelperTest class.

drivenflywheel
drivenflywheel requested changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested to follow common JUnit practices.

src/test/java/emissary/util/DisposeHelperTest.java Outdated Show resolved Hide resolved
@nixon124 nixon124 added the test-only The change only impacts test code label Nov 20, 2023
@jpdahlke jpdahlke added this to the v8.0.0-M10 milestone Nov 20, 2023
@nixon124 nixon124 changed the title Fixed Initialization Race Condition Fixed Initialization Race Condition in DisposeHelperTest Nov 20, 2023
drivenflywheel
drivenflywheel previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

fbruton
fbruton requested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@fbruton fbruton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest extending UnitTest.

drivenflywheel
drivenflywheel approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@drivenflywheel drivenflywheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jpdahlke jpdahlke merged commit a812cb0 into NationalSecurityAgency:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbruton fbruton fbruton approved these changes

@drivenflywheel drivenflywheel drivenflywheel approved these changes

Assignees
No one assigned
Labels
test-only The change only impacts test code
Projects
None yet
Milestone
v8.0.0-M10
Development

Successfully merging this pull request may close these issues.
4 participants
@nixon124 @drivenflywheel @fbruton @jpdahlke