Update Emissary to Java 11 #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- configuration stanza for sortpom should not show up in the executions portion
- Updated formatter plugin version and maven workflow - Workflow now executes with various check profiles enabled - Updated .gitignore to ignore formatter cache
ctubbsii
reviewed
Aug 26, 2020
Comment on lines
+70
to
+71
| <maven.compiler.source>11</maven.compiler.source> | ||
| <maven.compiler.target>11</maven.compiler.target> |
There was a problem hiding this comment.
You should specify maven.compiler.release for strict JDK11 compliance.
| @@ -902,7 +906,7 @@ | |||
| <plugin> | |||
| <groupId>net.revelc.code.formatter</groupId> | |||
| <artifactId>formatter-maven-plugin</artifactId> | |||
| <version>2.11.0</version> | |||
| <version>2.12.1</version> | |||
There was a problem hiding this comment.
You should use 2.12.2. I just released it, and it fixes an annoying bug.
dev-mlb
added
dependencies
fbruton
added a commit
to fbruton/emissary
that referenced
this pull request
Apr 15, 2021
fbruton
added a commit
to fbruton/emissary
that referenced
this pull request
Jul 25, 2021
fbruton
added a commit
to fbruton/emissary
that referenced
this pull request
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.