Add dim check to matrix_space
#1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 86.88% 86.93% +0.04%
==========================================
Files 116 116
Lines 29652 29621 -31
==========================================
- Hits 25764 25750 -14
+ Misses 3888 3871 -17 ☔ View full report in Codecov by Sentry. |
thofma
approved these changes
Apr 24, 2024
|
Maybe add a test if is not too much hassle? |
I'll get to it later, and do the same one for Nemocas/Nemo.jl#1729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Nemocas/Nemo.jl#1729 to address the issue described in Nemocas/Nemo.jl#1711.