-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Js/nc groebner basis documentation #1739
Js/nc groebner basis documentation #1739
Conversation
…ed functions to free_associative_algebra.md
… basis and extended the docstring of groebner_basis
…into js/nc_groebner_basis_documentation
> Xingqiang Xiu, | ||
> Non-commutative Gröbner Bases and Applications, | ||
> PhD thesis, 2012. | ||
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1739 +/- ##
=======================================
Coverage 87.39% 87.40%
=======================================
Files 117 117
Lines 29929 29929
=======================================
+ Hits 26157 26158 +1
+ Misses 3772 3771 -1 ☔ View full report in Codecov by Sentry. |
Do you still have plans to improve the code? E.g. the reduction code still is substantially slower than it could be as it uses |
Co-authored-by: Lars Göttgens <[email protected]>
@fingolfin Currently, I do not have any capacity to continue working on the code, so I am not planning to improve anything else at the moment. |
Thanks for the clarification @julien-schanz . I'll happily merge this, but the real issue with making these docs visible to OSCAR users is to make sure it is linked to in the OSCAR manual, see this OSCAR issue which I just opened. |
Expanded the documentation for the non-commutative groebner bases for free associative algebras.