Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js/nc groebner basis documentation #1739

Merged

Conversation

julien-schanz
Copy link
Contributor

Expanded the documentation for the non-commutative groebner bases for free associative algebras.

Comment on lines +241 to +244
> Xingqiang Xiu,
> Non-commutative Gröbner Bases and Applications,
> PhD thesis, 2012.

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.40%. Comparing base (72a7117) to head (168f250).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1739   +/-   ##
=======================================
  Coverage   87.39%   87.40%           
=======================================
  Files         117      117           
  Lines       29929    29929           
=======================================
+ Hits        26157    26158    +1     
+ Misses       3772     3771    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin
Copy link
Member

Do you still have plans to improve the code? E.g. the reduction code still is substantially slower than it could be as it uses _sub_rest (instead of geobuckets or the even simpler approach of using a hash table plus a heap (as e.g. described in section 4.1 of https://arxiv.org/abs/1206.6940).

@julien-schanz
Copy link
Contributor Author

@fingolfin Currently, I do not have any capacity to continue working on the code, so I am not planning to improve anything else at the moment.

@fingolfin
Copy link
Member

Thanks for the clarification @julien-schanz .

I'll happily merge this, but the real issue with making these docs visible to OSCAR users is to make sure it is linked to in the OSCAR manual, see this OSCAR issue which I just opened.

@fingolfin fingolfin merged commit f97f91d into Nemocas:master Jul 9, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants