Skip to content

Commit

Permalink
Update LICENSE.md
Browse files Browse the repository at this point in the history
  • Loading branch information
@thofma
thofma authored Jul 25, 2024
1 parent 1b72a9b commit c1316f8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions LICENSE.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ Individual parts of Nemo may be distributed according to more permissive terms a

This comment has been minimized.

Sign in to view

Copy link
@lgoettgens

lgoettgens Jul 25, 2024 •
edited
Loading

Collaborator

Since Flint v3.1, it is licensed with LGPLv3, see https://github.com/flintlib/flint/blob/main/doc/source/introduction.rst#license.
So L11 should be updated as well. @thofma

This comment has been minimized.

Sign in to view

Copy link
@fingolfin

fingolfin Jul 28, 2024

Member

Also the references in at least two parts to MPIR and MPFR can probably be removed
* The file ZZ.jl is licensed with the MIT license (see ZZ.jl for precise conditions of the license).

This comment has been minimized.

Sign in to view

Copy link
@lgoettgens

lgoettgens Jul 25, 2024

Collaborator

This file does (no longer) exist in this repo. So I think that this line should get removed from here (and L15 updated) @thofma

This comment has been minimized.

Sign in to view

Copy link
@fingolfin

fingolfin Jul 25, 2024

Member

Wrong it is now called fmpz.jl

I'll comment more when I am at a computer

This comment has been minimized.

Sign in to view

Copy link
@thofma

thofma Jul 28, 2024

Author Member

@fingolfin any comments?

This comment has been minimized.

Sign in to view

Copy link
@fingolfin

fingolfin Jul 28, 2024

Member

The file ZZ.jl is now src/flint/fmpz.jl. It retains a custom copyright header attributing credits to some Julia folks. It was derived from an early version of the Julia source file that defines the BigInteger type.

Looking at it, not much of that original code is left, and I'd argue most of it does not raise to the level of originality required for copyright, but of course this thing is always prone to interpretation. But it definitely is not appropriate to give sole credit for that file to the mentioned Julia authors.

So we can't simply delete this line, but we should update it. And then perhaps think about ways forwards: we could carefully inspect what is left from the original file added in 2014, and then perhaps the entire file can either be changed to be dual-licensed (arguably that should have been done from the start in 2014) or it might even be OK to change it to match the license of the rest of Nemo -- but that requires carefully reading the licenses. Ideally I would also try to contact the relevant authors of the Julia code to hear what they think (my guess would be that they'd not be bothered much either way, but I may of course be totally wrong, and I definitely wouldn't want to upset anyone over this).

* The Arb library is licensed LGPL v2.1+. The license text is supplied with the library, which is downloaded as part of the Nemo package installation.

* The individual .jl files (other than ZZ.jl) in the Nemo.jl package are licensed under the Simplified "2-clause" BSD License:

> Copyright (c) 2014-2016: William Hart, Tommy Hofmann, Claus Fieker, Fredrik

This comment has been minimized.

Sign in to view

Copy link
@fingolfin

fingolfin Jul 28, 2024

Member

If we discuss this file, then I feel we also need to discuss this line. It only extends a copyright claim until 2016, and to a small fixed list of authors which does not reflect the actual copyright holders of the code (there have been many other contributors since 2016).

In other projects I work on the list of people who made contributions are listed in a separate file.
Expand Down

0 comments on commit c1316f8

Please sign in to comment.