Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved two functions from Oscar to Nemo #1519

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ThomasBreuer
Copy link
Collaborator

@ThomasBreuer ThomasBreuer commented Jul 28, 2023

This is not yet satisfactory:

  • Should embed return something? The embed(k::T, K::T) where T <: FinField method returns a mapping, but the documentation does not state what is returned, and the code that calls embed seems to ignore the return value.
  • Tests and documentation are missing.

(And Run tests / test (~1.10.0-0, ubuntu-latest) (pull_request) got canceled.)

This is not yet satisfactory:

- Should `embed` return something?
  The `embed(k::T, K::T) where T <: FinField` method returns a mapping,
  but the documentation does not state what is returned,
  and the code that calls `embed` seems to ignore the return value.
- Tests and documentation are missing.
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1519 (cd11639) into master (38fd074) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1519      +/-   ##
==========================================
- Coverage   82.75%   82.73%   -0.03%     
==========================================
  Files          95       95              
  Lines       37186    37189       +3     
==========================================
- Hits        30773    30768       -5     
- Misses       6413     6421       +8     
Files Changed Coverage Δ
src/embedding/embedding.jl 98.40% <0.00%> (-1.06%) ⬇️
src/flint/fmpq.jl 85.64% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma
Copy link
Member

thofma commented Jul 28, 2023

Looks good. I will merge once we do the next breaking release.

@thofma thofma merged commit d411bf9 into Nemocas:master Sep 13, 2023
12 of 15 checks passed
lgoettgens added a commit to oscar-system/Oscar.jl that referenced this pull request Sep 13, 2023
lgoettgens added a commit to oscar-system/Oscar.jl that referenced this pull request Sep 13, 2023
@ThomasBreuer ThomasBreuer deleted the TB_move_from_Oscar branch September 14, 2023 07:31
lgoettgens added a commit to oscar-system/Oscar.jl that referenced this pull request Sep 14, 2023
thofma pushed a commit to oscar-system/Oscar.jl that referenced this pull request Sep 14, 2023
* Bump compats

* Remove functions moved to Nemo (Nemocas/Nemo.jl#1519)

* Fix `ZZ` printing (Nemocas/Nemo.jl#1506)

* Fix `identity_map` docstrings (Nemocas/AbstractAlgebra.jl#1431)

* Fix `PosInf` docstring (Nemocas/Nemo.jl#1528)

* Adapt doctests to new printing for maps Nemocas/AbstractAlgebra.jl#1424
fieker pushed a commit to oscar-system/Oscar.jl that referenced this pull request Sep 29, 2023
* Bump compats

* Remove functions moved to Nemo (Nemocas/Nemo.jl#1519)

* Fix `ZZ` printing (Nemocas/Nemo.jl#1506)

* Fix `identity_map` docstrings (Nemocas/AbstractAlgebra.jl#1431)

* Fix `PosInf` docstring (Nemocas/Nemo.jl#1528)

* Adapt doctests to new printing for maps Nemocas/AbstractAlgebra.jl#1424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants