Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two missing helper functions #1574

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add two missing helper functions #1574

merged 1 commit into from
Nov 2, 2023

Conversation

thofma
Copy link
Member

@thofma thofma commented Nov 2, 2023

  • Add lift for fq_default_poly -> ZZPolyRingElem - Generalize set_coeff! for qadic
  • Generalize set_coeff! for qadic

- Generalize set_coeff! for qadic
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #1574 (137209c) into master (978dd47) will decrease coverage by 0.03%.
Report is 4 commits behind head on master.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #1574      +/-   ##
==========================================
- Coverage   84.21%   84.18%   -0.03%     
==========================================
  Files          94       94              
  Lines       36634    36655      +21     
==========================================
+ Hits        30850    30858       +8     
- Misses       5784     5797      +13     
Files Coverage Δ
src/flint/fq_default_poly.jl 93.68% <100.00%> (+0.18%) ⬆️
src/HeckeMoreStuff.jl 3.23% <50.00%> (+0.38%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thofma thofma enabled auto-merge (squash) November 2, 2023 22:24
@thofma thofma merged commit 1acb178 into master Nov 2, 2023
14 of 15 checks passed
@thofma thofma deleted the th/loc branch November 2, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant