Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt QQBar documentation #1715

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Adapt QQBar documentation #1715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
764c2e6
Adapt QQBar documentation
lgoettgens Apr 11, 2024
61e8655
Prepare for not exporting `QQBar` and `CalciumQQBar`
lgoettgens May 15, 2024
7126705
Add note to doctestsetup
lgoettgens May 29, 2024
dd894a8
Apply suggestions from code review
fingolfin Jun 6, 2024
c80d76a
straighten out some tests
fingolfin Jun 6, 2024
dc5f40d
Remove two uses of QQBar
fingolfin Jun 6, 2024
48dcd18
Move deprecated (Calcium)QQBar to src/Deprecations.jl
fingolfin Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Deprecations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,9 @@ end
is_power(x::IntegerUnion) = is_perfect_power_with_data(x)
is_power(x::QQFieldElem) = is_perfect_power_with_data(x)
is_power(x::Rational) = is_perfect_power_with_data(x)

const QQBar = QQBarField()
export QQBar

const CalciumQQBar = QQBarField()
export CalciumQQBar
2 changes: 0 additions & 2 deletions src/Exports.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export bits
export bound_inf_norm
export CalciumField
export CalciumFieldElem
export CalciumQQBar # TODO: remove in next breaking release
export canonical_unit
export cdiv
export cdivpow2
Expand Down Expand Up @@ -502,7 +501,6 @@ export QadicFieldElem
export QQ
export QQAbsPowerSeriesRing
export QQAbsPowerSeriesRingElem
export QQBar # TODO: remove in next breaking release
export QQBarField
export QQBarFieldElem
export QQField
Expand Down
10 changes: 0 additions & 10 deletions src/Nemo.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,16 +592,6 @@ const FlintQQ = QQ
GaussianIntegers() = FlintZZi
GaussianRationals() = FlintQQi

###############################################################################
#
# Set domain for QQBar to Calcium
#
###############################################################################

@doc qqbar_field_doc
const CalciumQQBar = QQBar # TODO: remove in next breaking release


###############################################################################
#
# Some explicit type piracy against AbstractAlgebra
Expand Down
2 changes: 0 additions & 2 deletions src/calcium/CalciumTypes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ Root 0.866025 of 4x^2 - 3
struct QQBarField <: Field
end

const QQBar = QQBarField()

@doc qq_field_doc
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off-topic, but this is wrong. It should attach qqbar_field_doc instead

mutable struct QQBarFieldElem <: FieldElem
coeffs::Ptr{Nothing}
Expand Down
Loading