move code from Oscar.jl/experimental/GModule/Misc.jl here
#1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to add this code to Nemo.jl, and then to remove it from Oscar.jl. Concerning the usefulness of this code (and tests to be added), I am not sure which vectors shall be supported by the new methods; vectors of integers are already addressed by other methods.
|
We need to adjust the signature here at least a little bit to not have something like oscar-system/Oscar.jl#3576 again. |
fingolfin
approved these changes
Apr 19, 2024
|
I labeled this "breaking" for the same reason why Nemocas/AbstractAlgebra.jl#1675 is considered breaking. |
|
Yes, I will add tests. |
|
@ThomasBreuer I sent you an invite to this and the AA repository which hopefully will allow you to add labels, too |
lgoettgens
added a commit
to lgoettgens/Oscar.jl
that referenced
this pull request
May 2, 2024
lgoettgens
added a commit
to lgoettgens/Oscar.jl
that referenced
this pull request
May 2, 2024
lgoettgens
added a commit
to lgoettgens/Oscar.jl
that referenced
this pull request
May 2, 2024
lgoettgens
added a commit
to lgoettgens/Oscar.jl
that referenced
this pull request
May 3, 2024
thofma
pushed a commit
to oscar-system/Oscar.jl
that referenced
this pull request
May 4, 2024
* Bump dependencies * Remove moved aliases * Add `base_ring_type` methods * React to Nemocas/AbstractAlgebra.jl#1675 * React to Nemocas/Nemo.jl#1720 * Add QQBarField disambiguation method * Require AA 0.41.2 with `Generic.hom` fix * Add `base_ring(::QQAbField)` * Fix doctests * Fix booktests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to add this code to Nemo.jl, and then to remove it from Oscar.jl.
Concerning the usefulness of this code (and tests to be added), I am not sure which vectors shall be supported by the new methods; vectors of integers are already addressed by other methods.