Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify and crossref docstrings for GF and finite_field #1806

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

lgoettgens
Copy link
Collaborator

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (03e705a) to head (b027375).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
+ Coverage   85.96%   86.06%   +0.09%     
==========================================
  Files          98       98              
  Lines       36380    36397      +17     
==========================================
+ Hits        31274    31324      +50     
+ Misses       5106     5073      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/flint/fq_default.jl Outdated Show resolved Hide resolved
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SingularCI tests fail due to oscar-system/Singular.jl#811

src/flint/fq_default.jl Outdated Show resolved Hide resolved
src/flint/fq_default.jl Outdated Show resolved Hide resolved
src/flint/fq_default.jl Outdated Show resolved Hide resolved
src/flint/fq_default.jl Outdated Show resolved Hide resolved
src/flint/fq_default.jl Outdated Show resolved Hide resolved
@thofma
Copy link
Member

thofma commented Jun 28, 2024

In some other place we rephrased this "algebra generator", see the ?gen:

    gen(L::FqField)

  Return a K-algebra generator a of the finite field L, where K is the base field of L. The element a satisfies
  defining_polyomial(a) == 0.

  Note that this is in general not a multiplicative generator and can be zero, if L/K is an extension of degree
  one.

@lgoettgens lgoettgens enabled auto-merge (squash) July 1, 2024 19:29
@lgoettgens lgoettgens merged commit d8aeedc into Nemocas:master Jul 2, 2024
26 checks passed
@lgoettgens lgoettgens deleted the lg/GF-docstring branch July 2, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify and crossref docstrings for GF and finite_field
3 participants