Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion CalciumField, QQBar -> Float64 #1893

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

fingolfin
Copy link
Member

Work towards #1650

@fingolfin fingolfin requested a review from thofma October 12, 2024 23:24
src/calcium/qqbar.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.51%. Comparing base (0271fc0) to head (6100f3e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
- Coverage   87.51%   87.51%   -0.01%     
==========================================
  Files          97       97              
  Lines       35532    35536       +4     
==========================================
+ Hits        31096    31098       +2     
- Misses       4436     4438       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also avoid ccalls in conversion to ComplexF64
@fingolfin fingolfin changed the title Add conversion QQBar -> Float64 Add conversion CalciumField, QQBar -> Float64 Oct 31, 2024
@fingolfin
Copy link
Member Author

Updated, added also conversion from CalciumField to Float64, so this PR should now be ready 🥳

@lgoettgens lgoettgens enabled auto-merge (squash) October 31, 2024 07:48
@lgoettgens
Copy link
Collaborator

@benlorenz another instance where vinberg_2.jlcon needs absurd time: https://github.com/Nemocas/Nemo.jl/actions/runs/11607921085/job/32322223087?pr=1893#step:7:20023 cancelled by hand after about an hour in this single file

@lgoettgens lgoettgens merged commit 33043ef into Nemocas:master Oct 31, 2024
24 checks passed
@fingolfin fingolfin deleted the mh/Float64 branch October 31, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants