Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIS data concept shift #24

Merged
merged 10 commits into from
Aug 9, 2023
Merged

VIS data concept shift #24

merged 10 commits into from
Aug 9, 2023

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Aug 4, 2023

Changed the concept of primarily recording PDS-like "products" in the database and data
structures, and changed the concept to capture "records" of various kinds (ImageRecords,
LightRecords, and derived things like PanoRecords) in the database and as the primary
data unit for use and interaction. And then PDS "products" will be made at a later
time via a process that sources one or many records.

Added

  • image_records.py (this replaces the concept of raw_products.py)
  • create_image.py (this replaces most of the functionality of the previous
    create_raw.py)
  • light_records.py which handles information about luminaire state.

Changed

  • header.pga_gain_dict structure now has values that are always floats, which helps
    to determine whether this transformation needs to be applied.
  • image_stats.py is the new raw_stats.py, supporting ImageRecord objects.
  • pano_products.py is now pano_records.py, supporting ImageRecord objects.
  • create_pano.py now supports ImageRecords and PanoRecords.
  • create_raw.py rearchitected to gather information from "records" to build XML PDS
    labels.
  • create_vis_dbs entry point changed to vis_create_dbs to conform with other vis-related
    entry points.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the vipersci project uses, and I have submitted a CLA.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 72.69% and project coverage change: +3.68% 🎉

Comparison is base (fe49c24) 60.25% compared to head (79fc07b) 63.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   60.25%   63.94%   +3.68%     
==========================================
  Files          34       36       +2     
  Lines        2008     2072      +64     
==========================================
+ Hits         1210     1325     +115     
+ Misses        798      747      -51     
Files Changed Coverage Δ
src/vipersci/pds/pid.py 91.75% <ø> (+1.09%) ⬆️
src/vipersci/vis/header.py 48.00% <ø> (+8.00%) ⬆️
src/vipersci/vis/create_pano.py 37.89% <55.55%> (ø)
src/vipersci/vis/db/image_records.py 90.51% <66.66%> (ø)
src/vipersci/vis/create_image.py 70.09% <70.09%> (ø)
src/vipersci/vis/pds/create_raw.py 69.82% <70.12%> (+14.56%) ⬆️
src/vipersci/vis/db/light_records.py 89.65% <89.65%> (ø)
src/vipersci/__init__.py 100.00% <100.00%> (ø)
src/vipersci/vis/create_tif.py 100.00% <100.00%> (ø)
src/vipersci/vis/db/create_vis_dbs.py 100.00% <100.00%> (+100.00%) ⬆️
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeyer rbeyer merged commit e3c15f1 into main Aug 9, 2023
9 checks passed
@rbeyer rbeyer deleted the vis_record_concept branch August 9, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant