Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configuration options #227

Open
gegoune opened this issue Oct 12, 2021 · 4 comments
Open

Refactor configuration options #227

gegoune opened this issue Oct 12, 2021 · 4 comments
Labels

Comments

@gegoune
Copy link

gegoune commented Oct 12, 2021

Is your feature request related to a problem? Please describe.
Options aren't 'in the same direction' at the moment. Would be nice to remove disable_ strings from them and switch bools around.

{
  disable_signs = false,
  disable_hint = false,
  disable_context_highlighting = false,
  disable_commit_confirmation = false,
  auto_refresh = true,
  disable_builtin_notifications = false,
}

This is subset of current options. Please note how auto_refresh is 'positive' while all others are 'negative' (disable_).

Describe the solution you'd like
It would probably make sense to group related options into subtable and turn them around, so instead of disable_signs = false default would be signs = true, but also would be nested into, let's say, display subtable (display.signs = true).

Describe alternatives you've considered
Leave things as they are but setup table will eventually become polluted.

Additional context
#225 (comment)

@CKolkey
Copy link
Member

CKolkey commented Jul 30, 2023

@treatybreaker this could be something nice to do, yea?

@PriceHiller
Copy link
Contributor

@treatybreaker this could be something nice to do, yea?

Yeah, this would be solid. Not sure about the nested scope though. I don't think there's a ton of value in nesting the scope unless there's other values within that scope or we have repeated similar configs like with the kind stuff for commit_editor, commit_view, etc.

@CKolkey
Copy link
Member

CKolkey commented Jul 30, 2023

Dealers choice, I'm mostly interested in flipping the negative (disable_commit_confirm = true) into the positive commit_confirm = true

@D00mch
Copy link
Contributor

D00mch commented Dec 7, 2024

The pull request with the fix is here #1556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants