Skip to content

Commit

Permalink
Remove completed TODO comments (#13)
Browse files Browse the repository at this point in the history
Add release notes to GHA

Co-authored-by: Daniel McKnight <[email protected]>
  • Loading branch information
NeonDaniel and NeonDaniel authored Feb 26, 2024
1 parent 576ed37 commit 27edaa5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
with:
token: ${{secrets.GITHUB_TOKEN}}
tag: ${{env.VERSION}}
generateReleaseNotes: true
build_and_publish_docker:
uses: neongeckocom/.github/.github/workflows/publish_docker.yml@master
secrets: inherit
4 changes: 2 additions & 2 deletions neon_hana/schema/api_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ class ParseScriptRequest(BaseModel):
"no_val_1":
Execute: what time is it
Python: 1*2 # TODO: syntax check
Python: 1*2
LOOP check START
Set: new_val = no_val # This logs an error because it isn't declared
# TODO: The following should warn/error
# The following should warn/error
dne = "test"
voice_input(new_val)
LOOP check END
Expand Down
2 changes: 0 additions & 2 deletions neon_hana/schema/assist_requests.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ class TTSResponse(BaseModel):
}]}}


# TODO: User profile model with below inputs?

class SkillRequest(BaseModel):
utterance: str
lang_code: str
Expand Down

0 comments on commit 27edaa5

Please sign in to comment.