Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old patch #522

Merged
merged 2 commits into from
May 8, 2024
Merged

Remove old patch #522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5057645
Deprecate patched `add_event` method for latest ovos-workshop compat.
NeonDaniel May 8, 2024
f6cb931
Fix accidental changes
NeonDaniel May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions neon_utils/skills/neon_skill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
DEFAULT_SPEED_MODE = "thoughtful"
CACHE_TIME_OFFSET = 24*60*60 # seconds in 24 hours


@deprecated("deprecated without replacement, skill settings no longer shipped in skill folder", "2.0.0")
def save_settings(skill_dir, skill_settings):
"""Save skill settings to file."""
Expand Down Expand Up @@ -893,22 +894,3 @@ def init_dialog(self, root_directory: Optional[str] = None):
"""
log_deprecation("Use `load_dialog_files`", "2.0.0")
self.load_dialog_files(root_directory)

def add_event(self, name: str, handler: callable,
handler_info: Optional[str] = None, once: bool = False,
speak_errors: bool = True):
# TODO: Remove with ovos-workshop==0.0.13
try:
# Patching FakeBus compat. with MessageBusClient
if hasattr(self.bus, "ee"):
emitter = self.bus.ee
else:
emitter = self.bus.emitter
if handler_info == "mycroft.skill.handler" and \
emitter.listeners(name):
LOG.warning(f"Not re-registering intent handler {name}")
return
except Exception as e:
LOG.exception(e)
OVOSSkill.add_event(self, name, handler, handler_info, once,
speak_errors)
Loading