Add Prodigy Plus Schedule Free optimizer #614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Nerogar/OneTrainer?shareId=XXXX-XXXX-XXXX-XXXX).
…mizerParamsWindow.py` * Add `split_groups` parameter with title, tooltip, and type. * Adjust formatting for `cautious` parameter to align with new `split_groups` parameter.
…ate_optimizer` function in `modules/util/create.py`. * **Remove `decouple` parameter:** - Remove `decouple` parameter from the `create_optimizer` function for different optimizer configurations. * **Add `prodigy_steps` parameter:** - Add `prodigy_steps` parameter to the `create_optimizer` function for `PRODIGY_PLUS_SCHEDULE_FREE` optimizer configuration.
Nerogar
reviewed
Dec 25, 2024
| @@ -154,6 +159,11 @@ def create_dynamic_ui( | |||
|
|
|||
| # Extract the keys for the selected optimizer | |||
| for index, key in enumerate(OPTIMIZER_DEFAULT_PARAMETERS[selected_optimizer].keys()): | |||
| if selected_optimizer == Optimizer.PRODIGY_PLUS_SCHEDULE_FREE and key not in [ | |||
There was a problem hiding this comment.
Can you explain this change? I'm not quite sure if or why it's needed
There was a problem hiding this comment.
@saunderez Can you comment on this? I don't want to merge something if I don't understand why it's done
pretty broken |
This commit adds a variant of the Prodigy Optimizer created by LoganBooker https://github.com/LoganBooker/prodigy-plus-schedule-free/tree/main It is both learning rate free and schedule free. It also contains experiemntal optimization techniques as well as general memory usage and performance , improvmentsc Use with constant scheduler Based on code from: https://github.com/facebookresearch/schedule_free https://github.com/konstmish/prodigy Incorporates improvements from these pull requests (credit to https://github.com/dxqbYD and https://github.com/sangoi-exe): konstmish/prodigy#23 konstmish/prodigy#22 konstmish/prodigy#20 Supports fused backwards pass. Experimental featuures. ADOPT https://arxiv.org/abs/2411.02853 Cautious https://arxiv.org/pdf/2411.16085 MuonPP https://github.com/KellerJordan/Muon/blob/master/muon.py StableAdamW https://optimi.benjaminwarner.dev/optimizers/stableadamw/ Probably some other stuff I forgot. For full details
saunderez
force-pushed
the
add-prodigy-plus-schedule-free
branch
from
2e934c9 to
878c9c2
Compare
…aunderez/onetrainer into add-prodigy-plus-schedule-free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details, open the Copilot Workspace session.