Skip samples on training start #640
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we want a switch to just skip the first sample... ...or an interval, same as for checkpoint saves: [just a question - a switch is already useful on its own already] |
dxqbYD
reviewed
Jan 18, 2025
| @@ -495,6 +495,8 @@ def save(self, train_progress: TrainProgress, print_msg: bool = True, print_cb: | |||
| torch_gc() | |||
|
|
|||
| def __needs_sample(self, train_progress: TrainProgress): | |||
| if self.config.skip_sample_on_train_start and train_progress.epoch == 0 and train_progress.epoch_step == 0: | |||
There was a problem hiding this comment.
I think the same can be accomplished easier by passing start_at_zero==False to repeating_action_needed
There was a problem hiding this comment.
I will check this out then
hmm, probably the |
|
Yes. I also think it would be more useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a QoL option that makes OT skip sample generation when training starts.
I’ve been annoyed by this for a long time, always having to enable and disable samples at the start of each training session. 😉