Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复IOS端H5-选中视频-不触发成功/失败回调【latest】 #16943

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

zhengyanan1
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
IOS端浏览器环境,Taro.chooseMedia,选中视频时,无法触发成功/失败的回调

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@zhengyanan1 zhengyanan1 changed the title fix: 修复IOS端H5-选中视频-不触发成功/失败回调-latest fix: 修复IOS端H5-选中视频-不触发成功/失败回调【latest】 Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.52%. Comparing base (565ab79) to head (d5b8f2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/taro-h5/src/api/media/video/chooseMedia.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16943      +/-   ##
==========================================
- Coverage   58.52%   58.52%   -0.01%     
==========================================
  Files         466      466              
  Lines       27099    27102       +3     
  Branches     5935     5916      -19     
==========================================
+ Hits        15860    15861       +1     
- Misses       9759     9770      +11     
+ Partials     1480     1471       -9     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 52.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/taro-h5/src/api/media/video/chooseMedia.ts 7.14% <0.00%> (+0.57%) ⬆️

... and 27 files with indirect coverage changes

@tutuxxx tutuxxx added this to the 4.0.8 milestone Nov 29, 2024
@tutuxxx tutuxxx self-requested a review November 29, 2024 09:31
@tutuxxx tutuxxx merged commit 0828d8d into main Nov 29, 2024
37 of 38 checks passed
@tutuxxx tutuxxx deleted the fix/latest-ios_oncanplay branch November 29, 2024 09:34
This was referenced Nov 30, 2024
jxxbd91 pushed a commit to jxxbd91/taro that referenced this pull request Dec 2, 2024
@axetroy
Copy link

axetroy commented Dec 2, 2024

@tutuxxx @zhengyanan1

#14678 这个 issue 是不是也可以关掉了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants