Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added APIs to support fine-grained authorization #432

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Conversation

dmartinol
Copy link
Contributor

See issue #431

@dmartinol
Copy link
Contributor Author

Hi, could anyone have a look at this PR?

@Nerzal
Copy link
Owner

Nerzal commented Jul 5, 2023

The tests fail cause of a linter warning.
Could you fix that?

@Nerzal
Copy link
Owner

Nerzal commented Jul 6, 2023

Thank you for the contribution!
Could you also add 1 test case per new function?

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #432 (d7c3b29) into main (166f442) will decrease coverage by 1.66%.
The diff coverage is 0.00%.

❗ Current head d7c3b29 differs from pull request most recent head 19f8418. Consider uploading reports for the commit 19f8418 to get more accurate results

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   77.25%   75.60%   -1.66%     
==========================================
  Files           4        4              
  Lines        2198     2246      +48     
==========================================
  Hits         1698     1698              
- Misses        338      386      +48     
  Partials      162      162              
Impacted Files Coverage Δ
client.go 73.99% <0.00%> (-1.79%) ⬇️
models.go 90.32% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Enabled admin-fine-grained-authz feature
Replaced sleep 10 with loop to wait for health endpoint availability
Enabled admin-fine-grained-authz feature
Replaced sleep 10 with loop to wait for health endpoint availability
@dmartinol
Copy link
Contributor Author

Thank you for the contribution! Could you also add 1 test case per new function?

I added 2 and the coverage should increase, can you try?

@Nerzal
Copy link
Owner

Nerzal commented Jul 10, 2023

LGTM, thank you for the contribution!

@Nerzal Nerzal merged commit f08754e into Nerzal:main Jul 10, 2023
@dmartinol
Copy link
Contributor Author

LGTM, thank you for the contribution!

Thanks to you for maintaining this amazing client!
BTW: are you planning to create a new release soon, so we can integrate it in our application?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants