Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "direct naked impersonation" #465

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

tomqwpl
Copy link
Contributor

@tomqwpl tomqwpl commented Feb 17, 2024

Addresses issue #464

Happy if you want to change the method name :-)

@tomqwpl
Copy link
Contributor Author

tomqwpl commented Feb 17, 2024

Someone will have to help me understand what the lint complaint here is. As far as I can tell it's nothing to do with my code, but the lint output shows nothing in terms of where the error is. The code I added doesn't have "c", "err" or "token". The code in client_test.go contains:

func FailRequest(client *gocloak.GoCloak, err error, failN, skipN int) *gocloak.GoCloak {
	client.RestyClient().OnBeforeRequest(
		func(c *resty.Client, r *resty.Request) error {

That's the only reference to a "c" being an unused parameter I can see. So something appears to have changed in the linting?

@Nerzal Nerzal closed this Nov 5, 2024
@Nerzal Nerzal reopened this Nov 5, 2024
@Nerzal Nerzal merged commit 75aae0c into Nerzal:main Nov 5, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants