feat: consider Statement Conditions for iam:PassRole as valid in the statement conditions checker #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conditions checker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a user, I believe that the conditions_entries property on a Statement should reflect well-formed conditions when the Action is
iam:PassRole.iam:PassRoleuses a string based condition check. The example AWS Docs instruct us to evaluate the attributeaws:PassedToService.I didn't see a clean way of
ARN()ifying the value of aws:PassedToService, though presumably that would be part of a well-formed condition in this scenario. From my understanding, theaws:prefixed items that can appear in an IAM evaluation cannot have user-defined values, and as such maybe it's fine that the value of aws:PassedToService is coming through as "service.amazonaws.com" 🤷I hope that you'll consider this as an extension to the existing conditional evaluations.