-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for default Currency value #742
base: master
Are you sure you want to change the base?
Conversation
8158e9b
to
4cef9e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll leave it to the others to approve the java stuff
@@ -101,6 +106,11 @@ class Kotlin2CodeGenTest { | |||
assertCompilesKotlin(codeGenResult) | |||
} | |||
|
|||
@Test | |||
fun `assert updateExpected is false`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice add! ⭐
@srinivasankavitha should I do something about this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@iuliiasobolevska - do you want to take a look and merge when you get a chance? |
Hey 👋, something for both of you @srinivasankavitha and @mbossenbroek
closes #734