Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default Currency value #742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwilkolek
Copy link
Contributor

@dwilkolek dwilkolek commented Sep 8, 2024

Hey 👋, something for both of you @srinivasankavitha and @mbossenbroek

closes #734

@dwilkolek dwilkolek force-pushed the fix/734 branch 2 times, most recently from 8158e9b to 4cef9e5 Compare September 8, 2024 00:21
@dwilkolek dwilkolek changed the title Add support for default Currnecy value Add support for default Currency value Sep 8, 2024
Copy link
Contributor

@mbossenbroek mbossenbroek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll leave it to the others to approve the java stuff

@@ -101,6 +106,11 @@ class Kotlin2CodeGenTest {
assertCompilesKotlin(codeGenResult)
}

@Test
fun `assert updateExpected is false`() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add! ⭐

@dwilkolek
Copy link
Contributor Author

@srinivasankavitha should I do something about this PR?

Copy link
Contributor

@srinivasankavitha srinivasankavitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@srinivasankavitha
Copy link
Contributor

@iuliiasobolevska - do you want to take a look and merge when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Currency default value handling
3 participants