don't update engagement message for failed response (#3527)

* don't update engagement message for failed response * Update src/dispatch/plugins/dispatch_slack/case/interactive.py
Netflix · Jun 23, 2023 · 6f1a864 · 6f1a864
1 parent b67bc5e
commit 6f1a864
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/src/dispatch/plugins/dispatch_slack/case/interactive.py b/src/dispatch/plugins/dispatch_slack/case/interactive.py
@@ -1556,21 +1556,23 @@ def _send_response(success: bool) -> None:
             channel=case.conversation.channel_id,
             thread_ts=case.conversation.thread_id,
         )
-        blocks = create_signal_engagement_message(
-            case=case,
-            channel_id=case.conversation.channel_id,
-            engagement=engagement,
-            signal_instance=signal_instance,
-            user=user,
-            engagement_status=engagement_status,
-        )
-        client.chat_update(
-            blocks=blocks,
-            channel=case.conversation.channel_id,
-            ts=signal_instance.engagement_thread_ts,
-        )
 
         if success:
+            # We only update engagment message (which removes Confirm/Deny button) for success
+            # this allows the user to retry the confirmation if the MFA check failed
+            blocks = create_signal_engagement_message(
+                case=case,
+                channel_id=case.conversation.channel_id,
+                engagement=engagement,
+                signal_instance=signal_instance,
+                user=user,
+                engagement_status=engagement_status,
+            )
+            client.chat_update(
+                blocks=blocks,
+                channel=case.conversation.channel_id,
+                ts=signal_instance.engagement_thread_ts,
+            )
             _resolve_case(case)
 
     def _resolve_case(case: Case) -> None: