Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use sanitized jPaths #5299

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Only use sanitized jPaths #5299

merged 6 commits into from
Oct 8, 2024

Conversation

metroid-samus
Copy link
Contributor

No description provided.

@metroid-samus metroid-samus added the bug Something isn't working label Oct 8, 2024
@metroid-samus metroid-samus self-assigned this Oct 8, 2024
@metroid-samus metroid-samus marked this pull request as ready for review October 8, 2024 18:06
@wssheldon
Copy link
Contributor

I recommend we validate jpath on the backend to prevent creation of unsantized ones. If our version of Pydantic supports Annotated types, we could create one for jpath with a StringConstraint and use that as the type for the model values.

@metroid-samus metroid-samus merged commit cecb501 into master Oct 8, 2024
8 checks passed
@metroid-samus metroid-samus deleted the bugfix/do-not-execute-unsanitized-jsonpath branch October 8, 2024 20:10
@metroid-samus metroid-samus changed the title Does not execute jpath if it is not sanitized. Only use sanitized jPaths Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wssheldon wssheldon wssheldon approved these changes

Assignees

@metroid-samus metroid-samus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metroid-samus @wssheldon