Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused dependencies using nebula-linter #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed unused dependencies using nebula-linter #370

wants to merge 1 commit into from

Conversation

divyam-tripathi
Copy link

@divyam-tripathi divyam-tripathi commented Mar 18, 2023 •
edited
Loading

Context

Removed unused dependencies inside the project

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable

@divyam-tripathi divyam-tripathi temporarily deployed to Integrate Pull Request March 18, 2023 18:15 — with GitHub Actions Inactive
@divyam-tripathi divyam-tripathi mentioned this pull request Mar 18, 2023
Open
@github-actions
Copy link

Uploaded Artifacts

To use these artifacts in your Gradle project, paste the following lines in your build.gradle.

resolutionStrategy {
    force "io.mantisrx:mantis-client:0.1.0-20230318.233747-156"
    force "io.mantisrx:mantis-common:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-common-serde:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-discovery-proto:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-network:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-remote-observable:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-runtime:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-runtime-loader:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-shaded:0.1.0-20230318.233747-153"
    force "io.mantisrx:mantis-connector-iceberg:0.1.0-20230318.233747-153"
    force "io.mantisrx:mantis-connector-job:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-connector-kafka:0.1.0-20230318.233747-155"
    force "io.mantisrx:mantis-connector-publish:0.1.0-20230318.233747-154"
    force "io.mantisrx:mantis-control-plane-client:0.1.0-20230318.233747-154"
    force "io.mantisrx:mantis-control-plane-core:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-control-plane-server:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-core:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-groupby-sample:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-jobconnector-sample:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-mantis-publish-sample:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-sine-function:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-synthetic-sourcejob:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-twitter-sample:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-examples-wordcount:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-publish-core:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-publish-netty:0.1.0-20230318.233747-147"
    force "io.mantisrx:mantis-publish-netty-guice:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-server-agent:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-server-worker:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-server-worker-client:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-source-job-kafka:0.1.0-20230318.233747-148"
    force "io.mantisrx:mantis-source-job-publish:0.1.0-20230318.233747-148"
}

sundargates
sundargates reviewed Mar 19, 2023
View reviewed changes
Copy link
Collaborator

@sundargates sundargates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall! Let's wait for andy's comments in a couple of changes and then we can go ahead and merge it.

mantis-common/build.gradle
Comment on lines -44 to +43
testImplementation libraries.spectatorApi
implementation 'com.netflix.spectator:spectator-api:1.3.+'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andyz26 I'm guessing this config change is not doable? Can you take a look?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to include actual spectator lib in the common module.

mantis-server/mantis-server-worker/build.gradle
@@ -31,22 +31,18 @@ dependencies {

implementation "org.apache.mesos:mesos:$mesosVersion"
implementation libraries.slf4jApi
implementation libraries.slf4jLog4j12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change.

mantis-network/build.gradle
testImplementation libraries.spectatorApi
implementation 'com.netflix.spectator:spectator-api:1.3.+'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Not sure if this change is doable.

@divyam-tripathi
Copy link
Author

Hi @sundargates
Thanks for the review!, let me know if any further changes will be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundargates sundargates sundargates left review comments

@nickmahilani nickmahilani Awaiting requested review from nickmahilani

@jeffchao jeffchao Awaiting requested review from jeffchao

@piygoyal piygoyal Awaiting requested review from piygoyal

@calvin681 calvin681 Awaiting requested review from calvin681 calvin681 is a code owner

@Andyz26 Andyz26 Awaiting requested review from Andyz26 Andyz26 is a code owner

@hmitnflx hmitnflx Awaiting requested review from hmitnflx hmitnflx is a code owner

@markcho markcho Awaiting requested review from markcho

@liuml07 liuml07 Awaiting requested review from liuml07

@fdc-ntflx fdc-ntflx Awaiting requested review from fdc-ntflx fdc-ntflx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyam-tripathi @sundargates @Andyz26